Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlinks to symlinks are not evaluated properly during downstream sync #31

Open
pkubatrh opened this issue May 14, 2021 · 1 comment
Open
Assignees

Comments

@pkubatrh
Copy link
Member

pkubatrh commented May 14, 2021

Recently hit this issue when syncing with sclorg/s2i-nodejs-container#269

Seems like cwt is doing the right thing in re-evaluing the target of the symlink multiple times, but always uses the target that is present in upstream for the original symlink for the eventual copy:

rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../../test/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../common/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../common/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../common/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../common/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../common/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: looking for dangling symlink nodejs-14-minimal/test/check_imagestreams.py (that points to nodejs-14-minimal/test/../common/check_imagestreams.py)
rh_cwt.main.distgit - DEBUG: unlink nodejs-14-minimal/test/check_imagestreams.py
rh_cwt.main.distgit - DEBUG: cp upstreams/nodejs/14-minimal/test/../../test/check_imagestreams.py nodejs-14-minimal/test/check_imagestreams.py
@pkubatrh
Copy link
Member Author

FYI @phracek since you might hit the issue when using Betka

@phracek phracek self-assigned this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants