Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check fastify in case of nodej-18 and RHEL8, RHEL9 #435

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Jun 11, 2024

This pull request disabled testing fastify on nodejs-18 for RHEL8, and RHEL9.

@phracek phracek requested a review from lholmquist June 11, 2024 11:19
and RHEL8 and RHEL9.

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Jun 11, 2024

[test][test-upstream]

@phracek
Copy link
Member Author

phracek commented Jun 11, 2024

@pacostas Review please. Thanks. Fixed based on the mailing discussion.

Copy link
Contributor

@pacostas pacostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@lholmquist Can you also have a look?

@phracek phracek merged commit 2bb0b79 into master Jun 13, 2024
16 checks passed
@phracek phracek deleted the fastify_eol_18 branch June 13, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants