-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iPython craches when run as PID 1 #77
Comments
FWIW, I integrated I pull various source packages and compile from source code so don't have an issue with that, but if you have the restriction of only being able to use official packages that is likely going to be a problem unless there is something equivalent in package repositories already. |
@soltysh what's the likelihood that iPython gets fixed? this doesn't sound like a complexity we want to add to our images by default (and we'd need an rpm package of tini, if one doesn't exist, so we'd probably need the SCL team to adopt it) |
Reality is that no one would use the Red Hat S2I images if they want to build a Docker image for IPython. So is not a big deal. |
I think @GrahamDumpleton answered that question already. |
Given that, is there a compelling reason to keep this open? |
I think we can close it. It'll be kept here for reference for other folks struggling with similar problems. |
Thanks @soltysh |
Thank @GrahamDumpleton he pointed me to that problem 😄 |
I should have clarified that although no one will use this image for IPython, they will use the Tornado WSGI server and Tornado ASYNC server, Waitress WSGI server, plus others such as the Python standard library HTTP server. None of these will handle properly the pid 1 zombie reading and so eventually will crap out due to memory usage issues, or confusion due to reparenting of processes (as is case for IPython). Basically, if anyone supplies their own I will be posting a blog post about the issue as part of my series on porting IPython to Docker/OpenShift, highlighting how these other commonly used Python web servers can fail. |
@GrahamDumpleton that sounds perfect, can you please post a link to it in this issue? |
There's a known issue with iPython we might want to address somehow in the base image. The problem is that when running ipython with PID 1 (iow. using docker) it'll crash. You need a process that will handle that for you, as described here.
@bparees @rhcarvalho @GrahamDumpleton wdyt
The text was updated successfully, but these errors were encountered: