Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit size of status description to 140 character #187

Merged
merged 1 commit into from
May 23, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented May 21, 2024

HttpError: Validation Failed: {"resource":"Status","code":"custom","field":"description","message":"description is too long (maximum is 140 characters)"} - https://docs.github.com/rest/commits/statuses#create-a-commit-status
    at file:///home/runner/work/_actions/sclorg/testing-farm-as-github-action/v2/node_modules/@octokit/core/node_modules/@octokit/request/dist-bundle/index.js:106:1
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Job.doExecute (file:///home/runner/work/_actions/sclorg/testing-farm-as-github-action/v2/node_modules/bottleneck/light.js:405:1)

```ts
HttpError: Validation Failed: {"resource":"Status","code":"custom","field":"description","message":"description is too long (maximum is 140 characters)"} - https://docs.github.com/rest/commits/statuses#create-a-commit-status
    at file:///home/runner/work/_actions/sclorg/testing-farm-as-github-action/v2/node_modules/@octokit/core/node_modules/@octokit/request/dist-bundle/index.js:106:1
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Job.doExecute (file:///home/runner/work/_actions/sclorg/testing-farm-as-github-action/v2/node_modules/bottleneck/light.js:405:1)
```
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (5e49921) to head (e9f9e32).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files          10       10           
  Lines         685      685           
  Branches       70       72    +2     
=======================================
  Hits          605      605           
  Misses         78       78           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmiklank
Copy link
Contributor

[test]

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phracek phracek merged commit 2c15ff2 into sclorg:main May 23, 2024
10 of 11 checks passed
@jamacku jamacku deleted the description branch May 23, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants