Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Deploy Keyword List Component Type #593

Closed
Mars-PrakashSaini opened this issue May 9, 2023 · 4 comments · Fixed by #594
Closed

Unable to Deploy Keyword List Component Type #593

Mars-PrakashSaini opened this issue May 9, 2023 · 4 comments · Fixed by #594
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Mars-PrakashSaini
Copy link

What is the problem?

When I'm trying to retrieve keyword list and moderation rules using org browser, all the retrieved files goes into moderation folder.
and the type of file is .keyword-meta.xml and .rule-meta.xml for keyword list and moderation rules respectively.
and while running the CI/CD, it creates package only for moderation rules not for Keyword List.

Also when I'm creating the package manually on my local machine using git-delta, it's not capturing the keyword list (The behavior is same as above).

The git delta is unable to differnetiate between file .keyword-meta.xml and .rule-meta.xml and reading only .rule-meta.xml file type.

What is the parameter and the value you used with it?

sfdx sgd:source:delta --to HEAD --from $(previous_successfull_build_commit_id) --output . --ignore .packageignore

What is the expected result?

The generated package.xml should include below component type

Test.Banned
KeywordList


test.Replace_banned
test.Block_banned_keywords
test.Freeze_for_frequent_posting
test.Flag_banned
test.Review_the_first_post
ModerationRule

What is the actual result?

The delta command only picking up moderation rules and creating the package.xml with below only

test.Replace_banned
test.Block_banned_keywords
test.Freeze_for_frequent_posting
test.Flag_banned
test.Review_the_first_post
ModerationRule

Steps to reproduce

All Site > Open Workspace > Moderation Rules > Content Criteria > New > give name and unique name > Save. > Click on add and add the keywords whatever you want.

click on Moderation Rules > Create a new rule > Provide the values accordingly and Save.
NOw retrive the newly created keyword list and moderation rule and try to create the package using sgd-deta commands

sfdx sgd:source:delta --to HEAD --from $(previous_successfull_build_commit_id) --output . --ignore .packageignore

Operating System: … Windows

node version: … 18.0.0

git version: … 2.39.2.windows.1

sfdx version: … sfdx-cli/7.197.8

sgd plugin version: … v5.18.0

@Mars-PrakashSaini Mars-PrakashSaini added the bug Something isn't working label May 9, 2023
@scolladon scolladon added the good first issue Good for newcomers label May 9, 2023
@scolladon
Copy link
Owner

Hi @Mars-PrakashSaini !

Thanks for raising this issue and thanks for contributing in making this project better!

I can reproduce the issue, thanks to your very detailed steps.
We'll fix it asap and let you know when it is shipped.

Stay tuned !

@github-actions
Copy link

Shipped in release v5.18.1.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.18.1

@Mars-PrakashSaini
Copy link
Author

Hi @scolladon
Thanks a lot for looking into this issue.
after updating the version as v5.18.1, it's adding Keyword List component type in package.xml and working as expected.

@scolladon
Copy link
Owner

Hi @Mars-PrakashSaini !

Thanks to you ! I'm sure it will help others as well !

Next week it will be integrated in the latest version (thanks for your feedback)

Happy incremental deployment !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants