Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: missing "Open Alacritty here" context menu entry #12983

Closed
3 tasks done
jenbroek opened this issue Mar 21, 2024 · 0 comments · Fixed by #12997
Closed
3 tasks done

[Bug]: missing "Open Alacritty here" context menu entry #12983

jenbroek opened this issue Mar 21, 2024 · 0 comments · Fixed by #12997
Labels

Comments

@jenbroek
Copy link
Contributor

jenbroek commented Mar 21, 2024

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

alacritty

Expected/Current Behaviour

There is no context menu entry added after installing, unlike Alacritty's own installer1 does.

I would expect there to be a bundled registry file the user gets notified about when installing Alacritty, so they can import it afterwards to add the context menu entry.

Steps to Reproduce

scoop bucket add extras
scoop install extras/alacritty

Possible Solution

Looking at other manifests, like Windows Terminal2, I believe the following is needed:

  • install-context.reg and uninstall-context.reg files
  • post_install and pre_uninstall hooks
  • notes for informing the user about the install-context.reg file

See: #12997

Scoop and Buckets Version

Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
9e238aeb8 (HEAD -> master, origin/master, origin/HEAD) springboot: Update to version 3.2.4

'java' bucket:
c11b58e7 (HEAD -> master, origin/master, origin/HEAD) temurin17-nightly-jre: Update to version 17.0.11-7.0.ea

'main' bucket:
3b8aba5d0 (HEAD -> master, origin/master, origin/HEAD) llvm: Update to version 18.1.2

'nerd-fonts' bucket:
3811a43 (HEAD -> master, origin/master, origin/HEAD) SarasaGothic: Update to version 1.0.7

Scoop Config

last_update            scoop_branch scoop_repo
-----------            ------------ ----------
21/03/2024 03:21:00 PM master       https://github.com/ScoopInstaller/Scoop

PowerShell Version

Name                           Value
----                           -----
PSVersion                      7.4.1
PSEdition                      Core
GitCommitId                    7.4.1
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

No response

Footnotes

  1. https://github.com/alacritty/alacritty/blob/master/alacritty/windows/wix/alacritty.wxs#L41-L49

  2. https://github.com/ScoopInstaller/Extras/blob/master/bucket/windows-terminal.json

@jenbroek jenbroek added the bug label Mar 21, 2024
@jenbroek jenbroek changed the title [Bug]: missing "Alacritty Open here" context menu entry [Bug]: missing "Open Alacritty here" context menu entry Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant