Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PATCH on the root resource #44

Closed
acoburn opened this issue Apr 9, 2018 · 1 comment
Closed

Support PATCH on the root resource #44

acoburn opened this issue Apr 9, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@acoburn
Copy link
Contributor

acoburn commented Apr 9, 2018

Environment

Operating system: OS X

Python version: 3.6.4

LAKEsuperior release, branch, or commit #: 1.0.0-alpha12 from pypi

Steps to reproduce

  1. Start lakesuperior
  2. PATCH to the root container
curl -XPATCH -i localhost:8000/ldp/ -H"Content-Type: application/sparql-update" --data-binary @sparql.txt

(The same sparql update applied to a non-root resource succeeds)

INSERT {
    <> <http://purl.org/dc/terms/subject> [
       a <http://example.org/Subject> ;
       <http://www.w3.org/2000/01/rdf-schema#label> "A subject" ]
} WHERE {}

Observed behavior

Response:

HTTP/1.1 405 METHOD NOT ALLOWED
Server: gunicorn/19.7.1
Date: Mon, 09 Apr 2018 18:51:11 GMT
Connection: keep-alive
Content-Type: text/html
Allow: HEAD, POST, GET, OPTIONS
Content-Length: 178

Expected behavior

A successful response (e.g. 200 or 204)

Other notes worth mentioning

I notice that PATCH is not included in the Allow header, but the root resource also advertises the Allow-Patch header, so it's a little inconsistent.

@scossu scossu added this to the alpha.13 milestone Apr 9, 2018
@scossu scossu added the bug label Apr 9, 2018
@scossu scossu self-assigned this Apr 9, 2018
@scossu
Copy link
Owner

scossu commented Apr 10, 2018

Fixed in #50

@scossu scossu closed this as completed Apr 10, 2018
@scossu scossu mentioned this issue Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants