Skip to content
This repository has been archived by the owner on Nov 20, 2022. It is now read-only.

simplified exception handling #4

Merged
merged 5 commits into from Jul 28, 2021

Conversation

AnthonyZJiang
Copy link
Contributor

@AnthonyZJiang AnthonyZJiang commented Jul 23, 2021

Changes:

- Added __enter__ () to complete the code needed for with statement.

@scottburlovich scottburlovich changed the base branch from master to develop July 27, 2021 20:37
Copy link
Owner

@scottburlovich scottburlovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the __enter__ block @ L24-26, as the API wrapper is not used as a context manager. Other changes are OK.

@AnthonyZJiang AnthonyZJiang changed the title added __enter__ to work with __exit__, simplified exception handling simplified exception handling Jul 28, 2021
@AnthonyZJiang
Copy link
Contributor Author

Updated fixes for the latest upstream master.
Updated PR comments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants