Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

features.py get_text_features pandas 1x support #33

Closed
sykesdev opened this issue May 15, 2020 · 2 comments
Closed

features.py get_text_features pandas 1x support #33

sykesdev opened this issue May 15, 2020 · 2 comments
Assignees
@mrconway
Labels
bug

Comments

@sykesdev
Copy link

the following lines...

    min_length = int(feature.str.len().min())
    max_length = int(feature.str.len().max())

seem to fall foul of Pandas 1.x stricter rules. The following seems to work...

    min_length = int(feature.astype(str).str.len().min())
    max_length = int(feature.astype(str).str.len().max())
@mrconway
Copy link
Collaborator

mrconway commented May 15, 2020 •
edited

This is a fix in the next release.

@sykesdev sykesdev mentioned this issue May 29, 2020
Open
@mrconway mrconway mentioned this issue Jun 28, 2020
Closed
@mrconway mrconway added the bug label Aug 23, 2020
@mrconway mrconway self-assigned this Aug 23, 2020
@mrconway
Copy link
Collaborator

Fixed in 2.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrconway mrconway

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrconway @sykesdev