Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Facebook sign-in #14

Open
ScottishRoss opened this issue Oct 9, 2021 · 7 comments
Open

Enhancement: Facebook sign-in #14

ScottishRoss opened this issue Oct 9, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request hacktoberfest

Comments

@ScottishRoss
Copy link
Owner

Along with Google Sign-In, users should be able to sign in with a Facebook account.

Facebook sign-in implemented.
A new user is created on Facebook sign-in.
If that Users email already exists (i.e. via Google sign-in), the login details are combined.
Sign-out of Facebook button added to Preferences.

@ScottishRoss ScottishRoss added enhancement New feature or request hacktoberfest labels Oct 9, 2021
@saksham-gt
Copy link
Contributor

Can I take this issue? @ScottishRoss

@ScottishRoss
Copy link
Owner Author

@sudo-saksham I have made significant changes to the Develop branch to clean some stuff up. Can you make sure you pull the most recent develop branch.

@saksham-gt
Copy link
Contributor

Sure, I'll pull.

@saksham-gt
Copy link
Contributor

Can you create a separate branch on your repo for this feature? I'll make a PR into that branch itself so that if something's not correct than it won't affect the rest of the code. @ScottishRoss

@ScottishRoss
Copy link
Owner Author

That's what you're doing. If you clone the repo, create a new branch and work on that. You can then merge that locally to see if it works and raise the PR to the Develop branch on this repo.

@saksham-gt
Copy link
Contributor

saksham-gt commented Oct 31, 2021

Hey, I'm getting this error when I'm logging in with Facebook auth. I'm running this app on Android 11 and I have also implemented this FAQ answer given in the URL, but it's still showing me this and hence the token provided is null. Therefore, I cannot login with Facebook :

W/com.facebook.internal.NativeProtocol( 9966): Apps that target Android API 30+ (Android 11+) cannot call Facebook native apps unless the package visibility needs are declared. Please follow https://developers.facebook.com/docs/android/troubleshooting/#faq_267321845055988 to make the declaration.

Do you know what might be the solution? @ScottishRoss

@saksham-gt
Copy link
Contributor

For the reference, I implemented that suggestion given in the log like this : facebook_auth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants