Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkerManager for v3 #1

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments
Closed

MarkerManager for v3 #1

GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

Purpose of code changes on this branch:
It's a direct port of the markermanager from the v2 library.

When reviewing my code changes, please focus on:
The ProjectionHelper class, Bounds class and parts where you find v3
syntax. Don't forget the examples ;)

After the review, I'll merge this branch into:
Who knows, releases i guess ;)



Original issue reported on code.google.com by bbr...@gmail.com on 3 Mar 2010 at 10:32

@GoogleCodeExporter
Copy link
Author

Reviewed the following files:

http://code.google.com/p/google-maps-utility-library-v3/source/browse/trunk/mark
ermanager/src/markermanager.js?spec=svn81&r=80#44
http://code.google.com/p/google-maps-utility-library-v3/source/browse/trunk/mark
ermanager/examples/weather_map.html?spec=svn81&r=81#22
http://code.google.com/p/google-maps-utility-library-v3/source/browse/trunk/mark
ermanager/examples/google_northamerica_offices.html?spec=svn82&r=79#24


I actually reviewed the wrong revision, but we'll work it out later on.

Let me know if you have any questions about the comments.


Original comment by daniel...@google.com on 9 Mar 2010 at 11:52

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Thanks for the review, i will apply the changes you suggest, as soon as i can, 
but
will need to do it at home.

Original comment by bbr...@gmail.com on 10 Mar 2010 at 8:30

@GoogleCodeExporter
Copy link
Author

I changed the suggestions. I only didn´t comment on the bit shift because i 
really
can´t find the words at 8pm on friday :)

Commmited Revision 84

Original comment by bbr...@gmail.com on 12 Mar 2010 at 6:50

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Original comment by daniel...@google.com on 17 Mar 2010 at 9:33

  • Changed state: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant