Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngtemplate-loader doesn't support esModule option #186

Open
scottohara opened this issue Oct 31, 2021 · 0 comments
Open

ngtemplate-loader doesn't support esModule option #186

scottohara opened this issue Oct 31, 2021 · 0 comments

Comments

@scottohara
Copy link
Owner

html-loader allows us to import HTML files like this:

import AccountEditView from "accounts/views/edit.html";

html-loader@2.x defaults to esModule: true, which causes ngtemplate-loader to throw an error:

WARNING in ./src/accounts/controllers/index.ts 26:25-40
export 'default' (imported as 'AccountEditView') was not found in 'accounts/views/edit.html' (module has no exports)
 @ ./src/accounts/index.ts 7:0-57 17:42-64
 @ ./src/loot/index.ts 6:0-18

As a workaround, we simply set esModule: false on html-loader; but it would be nice if we didn't have to do this and could use the default settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant