Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the existence of mongita.errors.InvalidName necessary? #29

Open
PlatonB opened this issue Feb 12, 2022 · 2 comments
Open

Is the existence of mongita.errors.InvalidName necessary? #29

PlatonB opened this issue Feb 12, 2022 · 2 comments

Comments

@PlatonB
Copy link

PlatonB commented Feb 12, 2022

mongita.errors.InvalidName: Collection cannot be named 'Nerve_Tibial.v8.egenes_ann_query_res.vcf'.

It seems to me that the prohibition of presence of non-letter symbols in the collection name is superfluous. By the way, MongoDB does not have this restriction.

@scottrogowski
Copy link
Owner

There are restrictions on names in MongoDB (https://docs.mongodb.com/manual/reference/limits/) but you're right, I believe collections can contain periods in regular Mongo. If I recall correctly, I decided to veer towards more restrictive on the names because it is easy to loosen restrictions and very hard to add them later.

I would lean towards allowing periods if it's something you need to make your package work.

@PlatonB
Copy link
Author

PlatonB commented Feb 17, 2022

Multiple dots in file names is a common practice in bioinformatics. Renaming back and forth is certainly possible, but it's some extra work. MongoDB doesn't require this, which makes life a little easier:).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants