Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove everything *after* the hash (for specific links) #17

Open
mdbraber opened this issue Mar 12, 2024 · 2 comments
Open
Labels
feature request New feature or request

Comments

@mdbraber
Copy link

mdbraber commented Mar 12, 2024

Thanks for building Short Links! I'd like to shorten links with parameters such as from the PDF++ plugin [[File.pdf#selection=0,4,1,8]] to only show the part before the #, so removing everything after the #. It would be nicest is this would only be triggered on a RegEx pattern (e.g. internal links ending with .pdf) for the file name so the larger functionality stays intact.

See for more background: RyotaUshio/obsidian-pdf-plus#100

@scottwillmoore
Copy link
Owner

It is a good feature request, and something I would like to support. However, at the moment I don't have as much time as I used too, and therefore don't have any plan to implement this in the short-term. Would be happy to review a PR if anyone is interested.

@mdbraber
Copy link
Author

@scottwillmoore thanks - I'd be happy to submit a PR; I'll take a look when I can get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants