Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of data-default-class #316

Closed
ocramz opened this issue Oct 1, 2023 · 0 comments · Fixed by #386
Closed

Get rid of data-default-class #316

ocramz opened this issue Oct 1, 2023 · 0 comments · Fixed by #386
Labels
breaking change documentation easy fix feedback needed

Comments

@ocramz
Copy link
Collaborator

ocramz commented Oct 1, 2023

The Default typeclass is not well designed (https://markkarpov.com/post/data-default.html) and we use it here just to save some keystrokes to the user (once, when they scottyOpts or similar). Let's be explicit about our default settings instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change documentation easy fix feedback needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove data-default-class ocramz/scotty
1 participant
@ocramz