Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out test cases for WITHIN #47

Closed
scotws opened this issue Jun 8, 2018 · 0 comments
Closed

Figure out test cases for WITHIN #47

scotws opened this issue Jun 8, 2018 · 0 comments
Labels
enhancement Would't this be cool? testing Test suite stuff, not failed tests (those are bugs)

Comments

@scotws
Copy link
Owner

scotws commented Jun 8, 2018

WITHIN currently has no test cases, and there are none included in the standard (see https://forth-standard.org/standard/core/WITHIN) -- it just states that their implementation : WITHIN ( test low high -- flag ) OVER - >R - R> U< ; "works in all cases". Gforth (mirror at https://github.com/forthy42/gforth/blob/master/test/core.fs) also doesn't seem to test this. The problem is that the word gets tricky for signed and unsigned numbers, and it would be nice to do WITHIN in assembler because the JSR use lots of cycles for simple moves to and from the Return Stack.

@scotws scotws added enhancement Would't this be cool? testing Test suite stuff, not failed tests (those are bugs) labels Jun 8, 2018
@scotws scotws closed this as completed in 344e4cd Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Would't this be cool? testing Test suite stuff, not failed tests (those are bugs)
Projects
None yet
Development

No branches or pull requests

1 participant