Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import missing data (and possibly history?) from old repository #16

Open
4 of 7 tasks
Ede123 opened this issue Nov 18, 2015 · 6 comments
Open
4 of 7 tasks

Import missing data (and possibly history?) from old repository #16

Ede123 opened this issue Nov 18, 2015 · 6 comments

Comments

@Ede123
Copy link
Member

Ede123 commented Nov 18, 2015

While we're in the process of migrating data from the old repository, it might be a good time to check what else might be worth to keep. Personally I'd say the following should be considered:

  • History (see Import history from old repository #23)
    The full commit history of the relevant script files could be most useful when trying to figure out the idea behind parts of old code. However there are some issues:
    • I couldn't find a reasonable way to import the history of an old repository into a new one (that already has commits) without rebasing all of the new commits (which we probably don't want to do). Did I overlook something or is this just not the way git is meant to be used?
    • The only alternative possibility I could come up with was to convert the old repository from bzr to git and import it (including history) into a separate branch. This should work flawlessly (I already managed to do this locally) but besides having the old files available here on GitHub there's not much more to gain from this option.
  • Bugs
    Do we want to transfer the bugs currently on launchpad to GitHub?
  • Unittests (see Import unittests from old repository #15)
  • Release notes (see here)
    We should probably start to create release notes for new releases, too?
  • Icon (found here)
    It's surely nothing fancy, but we might want to keep it?

There are some more things I'm less sure about (and therefore would probably drop, at least at this point; we can still bring them back in one way or another in the future if needed):

  • Statistics
    For earlier versions there were some "fancy" statistics being made (see e.g. statistics.html and statistics.xls as well as the test files in the fulltests folder). They're surely nice to have and show what Scour actually does, but without somebody to maintain them they're of little use.
  • Web front-ends (see scra.py and webscour.py)

Feel free to comment on the above and add others if I missed something!

@Ede123
Copy link
Member Author

Ede123 commented Nov 19, 2015

Of course I forgot one important point:
Bugs (added to the list)

@Ede123
Copy link
Member Author

Ede123 commented Nov 21, 2015

@oberstet - If you have an opinion on any of the bullet points above (no matter whether positive or negative) just let us now.
I obviously don't expect you to start work on them, but if we know on which points we agree, I (or whoever else wants to help) can start working on them as they see fit.

The most important decision probably would be history since it might influence how we deal with the rest.

@oberstet
Copy link
Member

Thanks for the extensive list and useful structuring into separate issues! Awesome. Regarding the concrete list above: this all makes sense, however (given limited resources) I'd probably pick #15 as top prio. This really allows us to demonstrate continuity in scour development as we are adding more features. Compared to this, the rest of the points on the list seems "nice to have" to me ..

@Ede123
Copy link
Member Author

Ede123 commented Dec 6, 2015

I found a possible solution for the history import, see #23.

@oberstet
Copy link
Member

@Ede123 now that the unit tests are migrated, my personal next one on your list would be: bugs.

Regarding the others:

  • Logo: I've looked at it .. mmmh;) Really? And where should it be used anyway. I'd just skip that.
  • History: it's tricky, and I have doubts it's worth the efforts. The original authorship and whole lineage can always be dug out from launchpad .. for historians;)
  • Release notes: yes, that would be nice.

I also think the project README deserves some love. Plus: do we want some user docs? More cookbook/recipe like probably ..

FWIW, we have a 3 part blog post about SVG, also using scour http://tavendo.com/blog/post/preprocessing-svgs-for-the-web/

@Ede123
Copy link
Member Author

Ede123 commented Aug 28, 2016

  • History is already back since last week (see my comment in Import history from old repository #23).
  • I added and updated release notes this afternoon, see HISTORY.md
  • Bugs from Launchpad were just imported via lp2gh. (I created the account @launchpad-issue-importer for that).
    Since I didn't want to flood our repository with issues I limited the transfer to open bugs, though. Let's start triaging them... 😒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants