Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also text nodes have positions that can be scoured #76

Open
launchpad-issue-importer opened this issue Aug 28, 2016 · 2 comments
Open

Comments

@launchpad-issue-importer
Copy link

launchpad-issue-importer commented Aug 28, 2016

The list of nodes that contain length kind of attributes misses the "text" entity. Attached patch cares for that.


Imported from Launchpad using lp2gh.

@launchpad-issue-importer
Copy link
Author

(by pch-myzel)

@launchpad-issue-importer
Copy link
Author

launchpad-issue-importer commented Aug 28, 2016

(by louis-simard-deactivatedaccount)
The SVG specification says that x= and y= (and dx= and dy=) for may be lists of numbers instead of just numbers. The scourLength function doesn't appropriately react to having more than one number delimited by anything in its input string.

There are also some more length attributes in <text> that your patch doesn't cover, like dx=, dy= and textLength=, as well as more elements using the same attributes as <text>, such as <tspan> and <altGlyph>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants