Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PyPi release needed to stop generating migrations files for package #89

Closed
antsankov opened this issue Jun 13, 2022 · 3 comments
Closed

Comments

@antsankov
Copy link

antsankov commented Jun 13, 2022

In the latest release of django-softdelete, 0.9.3 -- Django makemigrations is generating a migration file for the softdelete package itself.

Based on this PR #88 (merged a week ago) it changes the default ID generation, so that a migration file is no longer generated

A release of the current master branch to PyPi should solve this issue.

Example:

$ ./manage.py makemigrations
Migrations for 'softdelete':
  /usr/local/lib/python3.8/dist-packages/softdelete/migrations/0004_alter_changeset_id_alter_softdeleterecord_id.py
    - Alter field id on changeset
    - Alter field id on softdeleterecord
@antsankov antsankov changed the title New PyPi release needed to stop generating migrations files Django 4.0+ New PyPi release needed to stop generating migrations files for package Jun 13, 2022
@PeterCarnesciali-minted

Yes, please make a new release so we can use that fix.

@scoursen
Copy link
Owner

I think it's been uploaded to pypi correctly.

@antsankov
Copy link
Author

Can confirm this works FYI - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants