Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Server-Timing syntax? #5

Closed
PikachuEXE opened this issue Mar 5, 2018 · 5 comments
Closed

Incorrect Server-Timing syntax? #5

PikachuEXE opened this issue Mar 5, 2018 · 5 comments

Comments

@PikachuEXE
Copy link

Env

Server
ruby_server_timing 1.0.1

Browser
Chrome: Version 64.0.3282.186 (Official Build) (64-bit)

Actual Output

server-timing:Middleware; dur=82.11; ,Router; dur=881.89; ,Controller; dur=152.58; ,ActiveRecord; dur=69.31; ,Redis; dur=356.72; ,View; dur=14509.94; ,Total; dur=16052.57;

screen shot 2018-03-05 at 3 46 37 pm

If I use https://github.com/dpogue/rails_server_timings
It outputs as

server-timing:view=0.794, db=0.882, redis=0.447, total=36.107

screen shot 2018-03-05 at 3 48 25 pm

@cvazac
Copy link
Contributor

cvazac commented Mar 5, 2018

Chrome 64 expects the old format:

Server-Timing: metric=123.4;the_description

Chrome 65+ (and other browsers when they implement the feature) expects the new format:

Server-Timing: metric;dur=123.4;desc=the_description

@itsderek23
Copy link
Contributor

Thanks @PikachuEXE for reporting and @cvazac for the background.

I'd prefer to keep it simple and stay consistent w/Chrome 65+ and future browser implementations. I've added a note to the README for others than run into an issue with Chrome 64:

9a10c2e

@PikachuEXE
Copy link
Author

Thanks
Do you know what version of Chromium are supporting the new format?
Since I use Vivaldi (based on Chromium) most of the time

@itsderek23
Copy link
Contributor

I believe Chrome 65+.

@itsderek23
Copy link
Contributor

Ah sorry @PikachuEXE - responded to fast. I'm not sure what version of Chromium (vs Chrome) uses the new format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants