Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Thread.sleep during build #527

Closed
hearnadam opened this issue Feb 6, 2024 · 1 comment · Fixed by #528
Closed

Avoid Thread.sleep during build #527

hearnadam opened this issue Feb 6, 2024 · 1 comment · Fixed by #528

Comments

@hearnadam
Copy link
Contributor

The comment in ScoverageSbtPlugin notes that this Thread.sleep(1000) was added to support Windows. Adding a 1s delay to otherwise performant builds is quite noticeable. The plugin could check the platform to avoid slowing down CI/CD, Linux, and Mac builds. Further, perhaps it's worth understanding why this issue is occurring in the first place.

Thread.sleep(
1000
) // have noticed some delay in writing on windows, hacky but works

Happy to open a PR, but opened the issue to understand if there was a deeper problem here.

@ckipp01
Copy link
Member

ckipp01 commented Feb 7, 2024

It was added before my time, so I'm really unsure what the back story was. Seeing the comment I'm open to adding a check here for the os and only doing this on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants