Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverageAggregate creates incorrect links #69

Closed
massenz opened this issue Nov 29, 2014 · 7 comments
Closed

coverageAggregate creates incorrect links #69

massenz opened this issue Nov 29, 2014 · 7 comments

Comments

@massenz
Copy link

massenz commented Nov 29, 2014

[issue originally reported in [Issue #13 ]]

I can confirm that the link to the sub-project's files are broken.
For example:

Link to a package summary page (resolves just fine):
file:///home/marco/workspaces/scala/sentinel/target/scala-2.11/scoverage-report/com.alertavert.sentinel.persistence.mongodb.html 

Link to the file (goes 404):
file:///home/marco/workspaces/scala/sentinel/sentinel_core/src/main/scala/com/alertavert/sentinel/persistence/mongodb/CreatorSerializer.scala.html

should be instead:

file:///home/marco/workspaces/scala/sentinel/sentinel_core/target/scala-2.11/scoverage-report/com/alertavert/sentinel/persistence/mongodb/CreatorSerializer.scala.html

is it possible that the path is taken from the XML (apart from the .html suffix, the path used resolves to the actual location of the .scala file)?

Cursorily browsing around, it would appear to me that the simplest fix would be to bring in everything from the sub-project's scoverage-report folder into the top-level project's folder, apart from the index.html, overview.html and packages.html - in the XML the refs to the source files are correct, and then adjust the links to the files.

@amosschallich
Copy link

I am also running into this issue. All of the links work for the sub-projects browsed individually, but as mentioned break in the aggregated version.

As a note, I am running 1.0.1

@sortega
Copy link

sortega commented Dec 12, 2014

I'm also being affected by this when trying 1.0.1

@randomcoder
Copy link

I have just found the same issue. However, to me the problem is that the link to the source.scala.html is an absolute path not relative.

<a href="/home/tim/code/CommonProjects/scala-utils/utils/src/main/scala/util/bytegenerator/BytePatternGenerator.scala.html">
          BytePatternGenerator
        </a>

should be (without leading /)

<a href="home/tim/code/CommonProjects/scala-utils/utils/src/main/scala/util/bytegenerator/BytePatternGenerator.scala.html">
          BytePatternGenerator
        </a>

So it would seem that the classRow method of the core HTML Writer is not quite working as expected?

@gslowikowski
Copy link
Member

Try 1.0.5-SNAPSHOT version please, add:

resolvers ++= Seq( Classpaths.sbtPluginSnapshots, Resolver.sonatypeRepo("snapshots") )

addSbtPlugin("org.scoverage" % "sbt-scoverage" % "1.0.5-SNAPSHOT")

to your project/plugins.sbt file.

@kurtkopchik
Copy link

Is there an ETA on when the official 1.0.5 version will be released? The aggregate reporting fix is working great in the snapshot release.

@RichardBradley
Copy link
Contributor

This is fixed now, I think.

@ckipp01
Copy link
Member

ckipp01 commented Apr 29, 2021

I believe this should be fixed now. If this is still an issue, please do report back.

@ckipp01 ckipp01 closed this as completed Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants