Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code documentation #186

Closed
petergthatsme opened this issue May 22, 2023 · 5 comments · Fixed by #189
Closed

Adding code documentation #186

petergthatsme opened this issue May 22, 2023 · 5 comments · Fixed by #189
Assignees

Comments

@petergthatsme
Copy link
Collaborator

petergthatsme commented May 22, 2023

We would like to add more complete documentation to the scqubits source code.

Here we ask for documenting signatures of 15 items such methods, functions, classes, etc, where the details are either incomplete, or missing completely.
Documentation should follow standards observed by the rest of the code.

Alternatively, fixing type annotation shown by rynning mypy . in the main folder would also qualify towards this goal.

@WingCode
Copy link
Contributor

WingCode commented May 26, 2023

@petergthatsme I would like to take a stab at this issue. Could you assign it to me?

@Algh89110377
Copy link

Hi Peter, I can also add documentation to the codes. Will you please add me?

@MihirsinhChauhan
Copy link

hey I'm interested ,
can you assign me this

@nathanshammah
Copy link

nathanshammah commented Jun 2, 2023

Just to clarify the rules of unitaryHACK (https://unitaryhack.dev/project-guide/): anyone is welcome to work on open issues, until they are closed. Issues do not need to be assigned to volunteers by maintainers before a pull request is approved (they can, but it's not required, and should not discourage other folks from participating). Thanks all for your interest!

@natestemen
Copy link

Congrats @WingCode for the successful hack! @petergthatsme Nice work with the actionable bounty as well.

Please ensure @WingCode is the only assignee to this issue so our systems know he should be rewarded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants