Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OrderedDict to dict #1108

Open
serhii73 opened this issue Dec 2, 2022 · 3 comments
Open

Replace OrderedDict to dict #1108

serhii73 opened this issue Dec 2, 2022 · 3 comments
Assignees

Comments

@serhii73
Copy link
Collaborator

serhii73 commented Dec 2, 2022

Makes sense wherever it does not affect external APIs.
e.g. if a function uses OrderedDict internally, then yes; if a function returns OrderedDict, we probably should follow a deprecation approach, e.g. deprecate that function (but keep it for a time) and provide a new one that returns a dict.

@PurviChaurasia
Copy link

Hey, if no one is working on this issue, I would like to work on it.

@PurviChaurasia
Copy link

Could you also specify whether this change needs to be done throughout the code repository or in a particular directory?

@serhii73
Copy link
Collaborator Author

Hi @PurviChaurasia
As far as I know, no one is working on this task. I think it makes sense to check the whole repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants