Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script to update the README table of supported languages and locales #601

Merged

Conversation

Gallaecio
Copy link
Member

Partial fix for #397.

Although sorted, the table contents are the same. Should the script be feeding additional languages and locales from sources other than dateparser.data.languages_info.language_locale_dict?

@Gallaecio Gallaecio force-pushed the necessary-documentation-improvements branch from df50951 to 0443fcd Compare December 13, 2019 12:40
@Gallaecio Gallaecio changed the title Necessary documentation improvements Add a script to update the README table of supported languages and locales Dec 13, 2019
@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #601 (d19b1a3) into master (939e722) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   98.33%   98.37%   +0.03%     
==========================================
  Files         231      231              
  Lines        2590     2591       +1     
==========================================
+ Hits         2547     2549       +2     
+ Misses         43       42       -1     
Impacted Files Coverage Δ
dateparser/date.py 100.00% <0.00%> (ø)
dateparser/languages/dictionary.py 100.00% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939e722...d19b1a3. Read the comment docs.

@Gallaecio Gallaecio closed this May 7, 2020
@Gallaecio Gallaecio reopened this May 7, 2020
@Gallaecio Gallaecio force-pushed the necessary-documentation-improvements branch from e49d3c9 to c0dc9ff Compare May 7, 2020 17:22
@noviluni
Copy link
Collaborator

I like the idea, but I don't think adding such a big table of supported locales to the README has any sense, so I will keep this PR open until we finish this: #723 and then we can work on this, to see if we want to move that table to the docs or whatever.

@noviluni
Copy link
Collaborator

Hi @Gallaecio!

This work would help a lot when updating the CLDR data: #826

The table was moved to the docs (supported_locales.rst). Could you update the code to work with it?

Regarding the source, I think it's OK to extract the language list from dateparser.data.languages_info.language_locale_dict. We could also get the list of supported locales from the modules in dateparser.data.date_translation_data, while the derived locales (locale + region) are in the locale_specific key, but I think that this is too tricky and it should be the same.

@Gallaecio Gallaecio force-pushed the necessary-documentation-improvements branch from d911bc2 to 9801f58 Compare November 11, 2020 16:42
Copy link
Collaborator

@noviluni noviluni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 💪

CONTRIBUTING.rst Outdated Show resolved Hide resolved
@Gallaecio Gallaecio merged commit 49dc8af into scrapinghub:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants