-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a script to update the README table of supported languages and locales #601
Add a script to update the README table of supported languages and locales #601
Conversation
df50951
to
0443fcd
Compare
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
==========================================
+ Coverage 98.33% 98.37% +0.03%
==========================================
Files 231 231
Lines 2590 2591 +1
==========================================
+ Hits 2547 2549 +2
+ Misses 43 42 -1
Continue to review full report at Codecov.
|
e49d3c9
to
c0dc9ff
Compare
I like the idea, but I don't think adding such a big table of supported locales to the README has any sense, so I will keep this PR open until we finish this: #723 and then we can work on this, to see if we want to move that table to the docs or whatever. |
Hi @Gallaecio! This work would help a lot when updating the CLDR data: #826 The table was moved to the docs (supported_locales.rst). Could you update the code to work with it? Regarding the source, I think it's OK to extract the language list from |
…tation-improvements
d911bc2
to
9801f58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 💪
Partial fix for #397.
Although sorted, the table contents are the same. Should the script be feeding additional languages and locales from sources other than
dateparser.data.languages_info.language_locale_dict
?