Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply STRICT_PARSING in no-spaces-time parser #715

Merged
merged 6 commits into from Sep 30, 2020
Merged

apply STRICT_PARSING in no-spaces-time parser #715

merged 6 commits into from Sep 30, 2020

Conversation

noviluni
Copy link
Collaborator

@noviluni noviluni commented Jun 19, 2020 •
edited

fixes: #713

It's just a WIP. I need to add some tests and probably move the functions to another place (like utils).

@noviluni noviluni mentioned this pull request Jun 19, 2020
Closed
@codecov
Copy link

codecov bot commented Jun 19, 2020 •
edited

Codecov Report

Merging #715 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         231      231           
  Lines        2520     2528    +8     
=======================================
+ Hits         2479     2487    +8     
  Misses         41       41
Impacted Files Coverage Δ
dateparser/parser.py 99.02% <100.00%> (+<0.01%) ⬆️
dateparser/utils/__init__.py 97.50% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aced969...579bf8b. Read the comment docs.

@noviluni noviluni added this to the v1.0.0 milestone Jun 22, 2020
@noviluni
Copy link
Collaborator Author

noviluni commented Jun 23, 2020 •
edited

I should probably accept and merge this: #515 before merging this to avoid breaking that PR.

@noviluni noviluni mentioned this pull request Jun 26, 2020
Draft
@noviluni noviluni mentioned this pull request Jul 23, 2020
Closed
@noviluni
Copy link
Collaborator Author

noviluni commented Sep 21, 2020 •
edited

This will be handled after this: #785

@noviluni noviluni modified the milestones: v1.0.0, 1.1.0 Sep 28, 2020
@noviluni noviluni marked this pull request as ready for review September 29, 2020 06:41
@noviluni noviluni changed the title WIP: apply STRICT_PARSING in no_space_parser apply STRICT_PARSING in no_space_parser Sep 29, 2020
@noviluni noviluni changed the title apply STRICT_PARSING in no_space_parser apply STRICT_PARSING in no-spaces-time parser Sep 29, 2020
@noviluni noviluni merged commit 5049620 into scrapinghub:master Sep 30, 2020
@noviluni noviluni modified the milestones: 1.1.0, v1.0.0 Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallaecio Gallaecio Gallaecio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Is there a way to ignore numbers unless they are epochs?
2 participants
@noviluni @Gallaecio