Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other words ("decade", "fortnight", "century"...) #725

Open
1 of 3 tasks
noviluni opened this issue Jun 25, 2020 · 4 comments
Open
1 of 3 tasks

Add support for other words ("decade", "fortnight", "century"...) #725

noviluni opened this issue Jun 25, 2020 · 4 comments

Comments

@noviluni
Copy link
Collaborator

noviluni commented Jun 25, 2020

There are some words that can be added to the library:

  • Decade: 10 years (2 decade --> 20 years, ...)
  • Fortnight: 14 days (Example: "a fortnight ago")
  • Century: 100 years (Example: "a century ago", "two centuries ago")

It's not necessary to put them all in a unique PR, you can submit just one of them. Just take in mind that it should support "next decade", "last decade", "a decade ago", "in a decade", but also "two decades ago".

@Gallaecio
Copy link
Member

We should see if we can get some of these words from CLDR data.

@seric17
Copy link
Contributor

seric17 commented Jul 25, 2020

Hi,
If no one else is already doing it, I'll try to add support for "decade".

@seric17
Copy link
Contributor

seric17 commented Aug 3, 2020

In my pull request #762, I made the assumption that "next decade" and "in a decade" both refer to "in 10 years". Similarly, I assumed that "last decade" and "a decade ago" both refer to "10 years ago". Please let me know if this makes sense and if there is anything else I should do. @noviluni

@noviluni
Copy link
Collaborator Author

noviluni commented Aug 4, 2020

Hi @seric17, thank you for submitting this PR, I will check it when having a moment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants