Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Python 3.9 support #732

Merged
merged 2 commits into from Jul 1, 2020
Merged

Conversation

noviluni
Copy link
Collaborator

@noviluni noviluni commented Jun 26, 2020

It will be released the 05/09/2020, just before the next planned release of dateparser.

@noviluni noviluni added this to the v1.0.0 milestone Jun 26, 2020
@noviluni
Copy link
Collaborator Author

should I change the used distro (xenial)? it is, in fact, necessary? 🤔

@Gallaecio
Copy link
Member

should I change the used distro (xenial)? it is, in fact, necessary?

I would remove the distro from all entries as long as test pass. In Scrapy we have a few jobs where it is needed, but in Dateparser it may not be needed at all.

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #732 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   95.23%   95.34%   +0.11%     
==========================================
  Files         302      304       +2     
  Lines        2560     2622      +62     
==========================================
+ Hits         2438     2500      +62     
  Misses        122      122              
Impacted Files Coverage Δ
dateparser/__init__.py 100.00% <0.00%> (ø)
dateparser/conf.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc38bb...a43c9d1. Read the comment docs.

@noviluni noviluni marked this pull request as ready for review June 29, 2020 20:18
@noviluni noviluni requested a review from Gallaecio June 30, 2020 14:33
@noviluni noviluni merged commit 940024e into scrapinghub:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants