Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calendars extra #740

Merged
merged 4 commits into from Jul 3, 2020
Merged

Conversation

noviluni
Copy link
Collaborator

@noviluni noviluni commented Jul 3, 2020

I noticed that pip install dateparser[calendars] didn't work. After some time investigating, it seems that there was a typo in extras_require.

I also updated the tox file after this change and the docs (that were wrong). The requirements.txt file will be deleted in this PR: #739

setup.py Outdated Show resolved Hide resolved
noviluni and others added 3 commits July 3, 2020 12:39
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #740 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #740   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files         304      304           
  Lines        2622     2622           
=======================================
  Hits         2500     2500           
  Misses        122      122           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e11a18a...e01066c. Read the comment docs.

@noviluni
Copy link
Collaborator Author

noviluni commented Jul 3, 2020

I added a temporary workaround (pinning a working regex package version) to make the Pypy pipeline pass.

As mentioned here: #565, it seems that dateparser doesn't work with Pypy out of the box because of the regex library which we depend on.

The next version will remove Python 2.7 support: #727 (and Pypy), so I hope we will remove this requirement pinning before releasing the next version.

I will investigate if this affects pypy3 to know if we can support it or not.

@noviluni noviluni requested a review from Gallaecio July 3, 2020 11:33
@noviluni noviluni merged commit 689390e into scrapinghub:master Jul 3, 2020
@noviluni noviluni mentioned this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants