Detect hours with period/dot as separator #741
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #643
fixes: #422
I worked on a solution for this issue and I got this. This is fully working and I added different cases to the tests coming from the issues. However, I think that this part of the code should be heavily refactored, as it's really hard to read, understand, and follow.
Solving this is not as trivial as it seems, because we use dots to separate the tokens, so it's hard to know when it's a valid HH.MM.