Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply 2to3 to clean code #748

Merged
merged 4 commits into from Jul 30, 2020

Conversation

noviluni
Copy link
Collaborator

closes: #747

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #748 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   95.23%   95.20%   -0.04%     
==========================================
  Files         304      304              
  Lines        2646     2629      -17     
==========================================
- Hits         2520     2503      -17     
  Misses        126      126              
Impacted Files Coverage Δ
dateparser/calendars/__init__.py 95.45% <ø> (-0.06%) ⬇️
dateparser/calendars/hijri_parser.py 89.74% <ø> (ø)
dateparser/calendars/jalali.py 100.00% <ø> (ø)
dateparser/calendars/jalali_parser.py 100.00% <ø> (ø)
dateparser/date_parser.py 100.00% <ø> (ø)
dateparser/languages/dictionary.py 99.32% <ø> (-0.01%) ⬇️
dateparser/search/__init__.py 100.00% <ø> (ø)
dateparser/search/search.py 98.05% <ø> (-0.02%) ⬇️
dateparser/search/text_detection.py 98.14% <ø> (-0.04%) ⬇️
dateparser/date.py 99.14% <100.00%> (-0.01%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0673c...de074c8. Read the comment docs.

@noviluni noviluni mentioned this pull request Jul 17, 2020
8 tasks
@noviluni noviluni requested a review from Gallaecio July 18, 2020 07:53
@@ -1,6 +1,6 @@
# coding: utf-8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you prefer to do it in a later changeset, this may be a good chance to get rid of these encoding comments as well.

And that way we don‘t need to discuss whether the empty lines between those and the first import line should be 1 or 2 🙂

Copy link
Collaborator Author

@noviluni noviluni Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this will be handled in another PR: #758 👍

dateparser/freshness_date_parser.py Outdated Show resolved Hide resolved
Co-authored-by: Adrián Chaves <adrian@chaves.io>
@noviluni noviluni merged commit 2cc91be into scrapinghub:master Jul 30, 2020
@noviluni noviluni added this to the v1.0.0 milestone Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants