New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply 2to3 to clean code #748
Apply 2to3 to clean code #748
Conversation
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
==========================================
- Coverage 95.23% 95.20% -0.04%
==========================================
Files 304 304
Lines 2646 2629 -17
==========================================
- Hits 2520 2503 -17
Misses 126 126
Continue to review full report at Codecov.
|
@@ -1,6 +1,6 @@ | |||
# coding: utf-8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you prefer to do it in a later changeset, this may be a good chance to get rid of these encoding comments as well.
And that way we don‘t need to discuss whether the empty lines between those and the first import line should be 1 or 2 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this will be handled in another PR: #758 👍
Co-authored-by: Adrián Chaves <adrian@chaves.io>
closes: #747