Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove numeral translation_data #782

Merged
merged 3 commits into from Sep 14, 2020

Conversation

noviluni
Copy link
Collaborator

The numeral_translation_data has been never used. Keeping these files makes the code maintainability harder and it's decreasing the coverage.

I think that these files were created and kept with the idea of being able to parse natural written numbers (for example: "twenty-five" for 25), however, this part will be supplied by a separate library called number-parser: https://github.com/scrapinghub/number-parser. PR: #711

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #782 into master will increase coverage by 2.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   95.57%   98.33%   +2.76%     
==========================================
  Files         304      231      -73     
  Lines        2600     2527      -73     
==========================================
  Hits         2485     2485              
+ Misses        115       42      -73     
Impacted Files Coverage Δ
dateparser/data/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ce6c9...a4babd7. Read the comment docs.

@noviluni
Copy link
Collaborator Author

Notice that the total coverage is increased by a tremendous +2.76%. 💪

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, 100% is getting closer 🎉

@noviluni noviluni merged commit 4f01811 into scrapinghub:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants