Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings while running tox -e doc command. #888

Merged
merged 5 commits into from
Mar 24, 2021

Conversation

kishan3
Copy link

@kishan3 kishan3 commented Feb 22, 2021

Helps fix #887

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #888 (efac9ae) into master (43fbc6a) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
+ Coverage   98.20%   98.26%   +0.06%     
==========================================
  Files         229      231       +2     
  Lines        2501     2597      +96     
==========================================
+ Hits         2456     2552      +96     
  Misses         45       45              
Impacted Files Coverage Δ
dateparser/date.py 99.22% <ø> (ø)
dateparser/__init__.py 100.00% <0.00%> (ø)
dateparser/conf.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43fbc6a...c612482. Read the comment docs.

@kishan3
Copy link
Author

kishan3 commented Feb 24, 2021

Hi @noviluni I have fixed the remaining warnings too now.

docs/modules.rst Outdated Show resolved Hide resolved
docs/template.rst Outdated Show resolved Hide resolved
docs/template.rst Outdated Show resolved Hide resolved
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup.

A good next step would be to make the documentation build fail in case of a warning. The -W parameter does that. But that can be done later in a separate pull request, I think.

Copy link
Collaborator

@noviluni noviluni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! 🚀 thanks @kishan3 ! 😄

@noviluni noviluni merged commit 21c629f into scrapinghub:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues when building the docs
3 participants