-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings while running tox -e doc command. #888
Conversation
This should help fix scrapinghub#887
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
+ Coverage 98.20% 98.26% +0.06%
==========================================
Files 229 231 +2
Lines 2501 2597 +96
==========================================
+ Hits 2456 2552 +96
Misses 45 45
Continue to review full report at Codecov.
|
Hi @noviluni I have fixed the remaining warnings too now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup.
A good next step would be to make the documentation build fail in case of a warning. The -W
parameter does that. But that can be done later in a separate pull request, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! 🚀 thanks @kishan3 ! 😄
Helps fix #887