Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Makefile #907

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Remove Makefile #907

merged 1 commit into from
Apr 9, 2021

Conversation

noviluni
Copy link
Collaborator

@noviluni noviluni commented Apr 9, 2021

The Makefile is something that hasn't been maintained for a long time.

This package is usually installed through pip, so the make options are not used. On the other hand, for development we currently use tox, which is able to handle:

  • testing (pytest) and coverage: tox -e py3
  • linting (flake8 through pytest-flake8): tox -e flake8
  • docs building: tox -e docs

With this said, I think we don't need the Makefile anymore, and by removing it we can ease the project maintenance.

Closes #892, closes #893

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #907 (d3dd954) into master (21c629f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #907   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         231      231           
  Lines        2597     2597           
=======================================
  Hits         2552     2552           
  Misses         45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c629f...d3dd954. Read the comment docs.

@noviluni noviluni merged commit c15098e into scrapinghub:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make virtual environment for dateparser
2 participants