Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 刚刚 #910

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Conversation

noviluni
Copy link
Collaborator

@noviluni noviluni commented Apr 12, 2021

Fixes: #854

Now dateparser.parse("刚刚") returns "now" instead of None.

@noviluni noviluni requested a review from peonone April 12, 2021 10:33
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #910 (2ac4719) into master (c15098e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #910   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         231      231           
  Lines        2597     2597           
=======================================
  Hits         2552     2552           
  Misses         45       45           
Impacted Files Coverage Δ
dateparser/data/date_translation_data/zh.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15098e...2ac4719. Read the comment docs.

Copy link
Member

@peonone peonone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @noviluni , thanks for adding this!

@noviluni noviluni merged commit 255c421 into scrapinghub:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are two time styles that cannot be resolved (original: 有两种时间样式无法解析)
2 participants