Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflow to publish project on PyPI when released #911

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

rennerocha
Copy link
Contributor

When Travis was removed, the steps to deploy new versions on PyPI was removed too. This PR includes a new workflow that will publish to PyPI every time a new release is made.

@Gallaecio , I don't have access, but probably we already have these secrets configured for this repository, am I right?

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #911 (61e090c) into master (255c421) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #911   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         231      231           
  Lines        2597     2597           
=======================================
  Hits         2552     2552           
  Misses         45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 255c421...61e090c. Read the comment docs.

@Gallaecio
Copy link
Member

@Gallaecio , I don't have access, but probably we already have these secrets configured for this repository, am I right?

I’ve added it now :)

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noviluni Just for your information: with this change, the package is deployed to PyPI when a release entry is created in GitHub, in https://github.com/scrapinghub/dateparser/releases, not when a version tag is pushed.

@noviluni
Copy link
Collaborator

Nice! I think it's time to release a new version, so I will merge it just before doing it and will see if it works :)

thanks both @Gallaecio @rennerocha

@noviluni noviluni merged commit 41f9478 into scrapinghub:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants