Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider RETURN_TIME_AS_PERIOD for timestamp times #922

Merged
merged 2 commits into from
May 25, 2021

Conversation

onlynone
Copy link
Contributor

This should fix #920

@onlynone onlynone force-pushed the time_as_period_for_timestamp branch from ef7afe8 to e424c1a Compare May 13, 2021 01:39
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #922 (cb58b9f) into master (255c421) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #922   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         231      231           
  Lines        2597     2597           
=======================================
  Hits         2552     2552           
  Misses         45       45           
Impacted Files Coverage Δ
dateparser/date.py 99.22% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 255c421...cb58b9f. Read the comment docs.

@noviluni
Copy link
Collaborator

Hi @onlynone! Thanks for opening this PR.

This definitely should work. Could you add a test that covers this change?

@noviluni
Copy link
Collaborator

I think it's not necessary to add the 4 examples to the test, but it's ok for me.

@noviluni
Copy link
Collaborator

cc: @Gallaecio

@Gallaecio Gallaecio merged commit 803d445 into scrapinghub:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider RETURN_TIME_AS_PERIOD for datetimes parsed as seconds since the epoch
3 participants