Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing redundant parenthesis #951

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Conversation

gavishpoddar
Copy link
Contributor

This PR will remove redundant parenthesis in parser.py:L357

Thanks.

@gavishpoddar
Copy link
Contributor Author

Hi, @noviluni can you please suggest.

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #951 (81f6859) into master (803d445) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #951   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         231      231           
  Lines        2597     2597           
=======================================
  Hits         2552     2552           
  Misses         45       45           
Impacted Files Coverage Δ
dateparser/parser.py 99.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803d445...81f6859. Read the comment docs.

Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gavishpoddar 👍

@lopuhin lopuhin merged commit ad50964 into scrapinghub:master Jul 26, 2021
@gavishpoddar gavishpoddar deleted the patch branch July 26, 2021 16:31
@gavishpoddar gavishpoddar changed the title removing redundant parenthesis Removing redundant parenthesis Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants