Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in locale:translate_search fixes #953

Merged
merged 4 commits into from
Aug 9, 2021

Conversation

gavishpoddar
Copy link
Contributor

This PR fixes #930

Adds support for last decade, next decade, etc in search_dates

PL suggest if any change is required.

Thanks

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #953 (ecbfc2b) into master (ad50964) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #953   +/-   ##
=======================================
  Coverage   98.26%   98.27%           
=======================================
  Files         231      231           
  Lines        2597     2609   +12     
=======================================
+ Hits         2552     2564   +12     
  Misses         45       45           
Impacted Files Coverage Δ
dateparser/languages/locale.py 98.69% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad50964...ecbfc2b. Read the comment docs.

@gavishpoddar gavishpoddar changed the title improvements in locale: translate_search fixes #930 Improvements in locale: translate_search fixes Jul 26, 2021
@gavishpoddar gavishpoddar changed the title Improvements in locale: translate_search fixes Improvements in locale:translate_search fixes Jul 26, 2021
Copy link
Collaborator

@noviluni noviluni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
All tests are passing, so it seems that it works pretty good without breaking anything 💪

We can merge it when addressing the suggestions! :)

dateparser/languages/locale.py Outdated Show resolved Hide resolved
dateparser/languages/locale.py Outdated Show resolved Hide resolved
dateparser/languages/locale.py Outdated Show resolved Hide resolved
dateparser/languages/locale.py Outdated Show resolved Hide resolved
gavishpoddar and others added 2 commits July 27, 2021 15:12
Co-authored-by: Marc Hernández <noviluni@gmail.com>
@gavishpoddar
Copy link
Contributor Author

Thanks, @noviluni, for the quick review, I have made the changes you suggested.

gavishpoddar added a commit to gavishpoddar/dateparser that referenced this pull request Aug 4, 2021
@Gallaecio Gallaecio merged commit c5f0fa4 into scrapinghub:master Aug 9, 2021
@gavishpoddar gavishpoddar deleted the fixing-locale-translate branch August 17, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with search_dates('last decade')
3 participants