Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogenize flake8 line length #957

Merged
merged 4 commits into from
Aug 9, 2021
Merged

Conversation

noviluni
Copy link
Collaborator

@noviluni noviluni commented Aug 7, 2021

We set a max length of 119 characters and the flake8 on the pipelines was using that value from the pytest.ini (flake8-max-line-length). However, there were some references to 100 characters. I updated the docs (CONTRIBUTING.rst) and the setup.cfg.

On the other hand, when using the flake8 tool directly (instead of using it along with tox), the flake8 file wasn't working. I checked the flake8 documentation, and that file is not accepted, in any case, it should start with a period (.flake8):

Flake8 supports storing its configuration in the following places:

  • Your top-level user directory
  • In your project in one of setup.cfg, tox.ini, or .flake8.

So I removed it. Then I also realized that it would be a good idea to have a "single point of truth", and as pytest-flake8 will take the values from the setup.cfg, I removed the flake8-max-line-length from the pytest.ini.

Finally, and following with the last idea, I moved the flake8 excusion rules to the setup.cfg.

@noviluni noviluni requested a review from Gallaecio August 7, 2021 09:38
@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #957 (e49c7f0) into master (ad50964) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #957   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         231      231           
  Lines        2597     2597           
=======================================
  Hits         2552     2552           
  Misses         45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad50964...e49c7f0. Read the comment docs.

CONTRIBUTING.rst Outdated Show resolved Hide resolved
Co-authored-by: Adrián Chaves <adrian@chaves.io>
@Gallaecio Gallaecio merged commit 134cf24 into master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants