Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github actions (language pack fr) #966

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix github actions (language pack fr) #966

merged 1 commit into from
Aug 19, 2021

Conversation

noviluni
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #966 (af4f46e) into master (c5f0fa4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #966   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         231      231           
  Lines        2609     2609           
=======================================
  Hits         2564     2564           
  Misses         45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f0fa4...af4f46e. Read the comment docs.

@noviluni noviluni mentioned this pull request Aug 18, 2021
21 tasks
Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @noviluni 👍

@lopuhin lopuhin merged commit ab96be9 into master Aug 19, 2021
@lopuhin lopuhin deleted the fix_github_actions branch August 19, 2021 10:00
@lopuhin
Copy link
Member

lopuhin commented Aug 19, 2021

The build still failed for py35 but it's a different reason: https://github.com/scrapinghub/dateparser/runs/3370394856?check_suite_focus=true

Btw I wonder if it would be fine to drop support for python 3.5? I think many popular libraries dropped it a long time ago.

@noviluni
Copy link
Collaborator Author

The build still failed for py35

Hi @lopuhin, that error is really weird, it says that it couldn't find the convertdate package. I re-runed the pipelines and it worked. Seems more like an error in PyPI, not something related to Python 3.5.

it would be fine to drop support for python 3.5?

Yeah, I was thinking about deprecating Python 3.5, but I thought it could be better to wait one version more, as this new version (that I plan to release right after the GSoC) will include a lot of fixes and all is compatible with Python 3.5, so it would be nice to keep the support at least one more version. For me it's totally fine to update to Python 3.6 the next of the next version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants