fix(regex-version): removed version 2021.8.27 that breaks dateparser with SegFault #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athossampayo
changed the title
noviluni
requested changes
Aug 31, 2021
There was a problem hiding this comment.
Hi @athossampayo, thank you for opening this PR. I think the correct way to do it is separating the versions with commas, as set in PEP-440: 'regex !=2019.02.19,!=2021.8.27',
Could you try with these semantics?
Thanks! :)
…with SegFault Related to scrapinghub#972
athossampayo
force-pushed
the
remove-regex-broken-version
branch
from
9853019
to
ce4dc15
Compare
|
Hello @noviluni, thanks for the tip! Did not find a pattern to follow on this case. Already updated the code. If there's anything more to fix, just say. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 231 231
Lines 2609 2609
=======================================
Hits 2564 2564
Misses 45 45 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(regex-version): removed version 2021.8.27 that breaks dateparser with SegFault
Related to #972
Tests result:
Fixes: #972.
Fixes: #973