Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: Reduce log level of "Failed to schedule job" messages #54

Open
curita opened this issue Feb 5, 2024 · 0 comments
Open

suggestion: Reduce log level of "Failed to schedule job" messages #54

curita opened this issue Feb 5, 2024 · 0 comments

Comments

@curita
Copy link
Member

curita commented Feb 5, 2024

Background

Sometimes shub-workflow fails to schedule a job and retries the action until it succeeds or runs out of attempts.

In those situations, those "Failed to schedule job" messages will be reported as Errors, even though they don't require user actions other than waiting for those retries to finish.

Proposal

It would be nice for these messages to be considered warnings:

logger.error(f"Failed to schedule job with arguments {schedule_kwargs}: {e}")

So they aren't flagged by monitors supervising log messages. If all retries made by @dash_retry_decorator fail, then the original issue is reraised, which seems to be reported as an error already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant