Google fonts @import url() raises SelectorSyntaxError in parse_simple_selector

[mxdubois]

Got this error: Expected selector, got <NUMBER '700' at 0>

I think it was caused by this line in my css:
@import url('https://fonts.googleapis.com/css?family=Lato:400,700,400italic|Signika:400,700');

I'm using premailer which uses your library.

[SimonSapin]

Hi. @import rules have nothing to do with selectors. Are you sure this is about cssselect rather than tinycss?

Anyway, could you provide sample code to reproduce the issue, and a full traceback?

[SimonSapin]

Ok, it appears that you’re asking cssselect to parse something that is not a Selector at all, which as expected gives a syntax error. I think the bug is in your code, which should do a better job at recognizing what is a style rule or not. This might be related to the fact that you’re parsing CSS with regexps. This is about parsing HTML, but I think it applies equally well here.

Consider using an actual CSS parser like tinycss. With tinycss you can test if some_rule.at_keyword is None: … to only pick style rules (as opposed to at-rules such as @import.)

[SimonSapin]

Sorry for the mix up. By "you" in the previous message I mean premailer.

[mxdubois]

Haha. Np. So it's an issue with premailer's parsing. Your library's not supposed to handle @import. I'll file an issue over there then and link them here for reference to your comments.

Thanks for the help.