Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing in parsel.selector._ctgroup #264

Closed
wRAR opened this issue Nov 1, 2022 · 2 comments
Closed

Improve typing in parsel.selector._ctgroup #264

wRAR opened this issue Nov 1, 2022 · 2 comments
Labels
enhancement

Comments

@wRAR
Copy link
Member

wRAR commented Nov 1, 2022

parsel.selector._ctgroup, used to switch between mode implementations, is an untyped dict of dicts, it makes sense to change it into something cleaner as it's a private var.
@wRAR
Copy link
Member Author

wRAR commented Nov 22, 2022

TypedDict could be used, though maybe it's easier to just use a normal dataclass or something similar (especially as TypedDict doesn't exist in 3.7).

@wRAR wRAR mentioned this issue Apr 11, 2023
Merged
2 tasks
@wRAR
Copy link
Member Author

wRAR commented Apr 11, 2023

Implemented in #181.

@wRAR wRAR closed this as completed Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wRAR