Add a test for a CrawlerProcess script. #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4218 +/- ##
==========================================
- Coverage 83.86% 83.85% -0.02%
==========================================
Files 165 165
Lines 9615 9615
Branches 1440 1440
==========================================
- Hits 8064 8063 -1
Misses 1304 1304
- Partials 247 248 +1
|
Gallaecio
reviewed
Dec 6, 2019
Gallaecio
approved these changes
Dec 7, 2019
Gallaecio
pushed a commit
to Gallaecio/scrapy
that referenced
this pull request
Dec 17, 2019
* Add a test for a CrawlerProcess script. * Add tests/CrawlerProcess to collect_ignore. * Remove an extra line. * Fix/improve conftest.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.