Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Slot classes back? #4296

Open
wRAR opened this issue Jan 31, 2020 · 5 comments
Open

Merge Slot classes back? #4296

wRAR opened this issue Jan 31, 2020 · 5 comments

Comments

@wRAR
Copy link
Member

wRAR commented Jan 31, 2020

In 409aaad scrapy.core.engine.Slot was extracted from scrapy.core.engine.ExecutionEngine and they had a many-to-one rel. In a84e5f8 that rel was changed to one-to-one, and I'm not sure what does this split achieve now.

@wRAR wRAR changed the title Merge Slot back into ExecutionEngine? Merge Slot classes back? Jan 31, 2020
@wRAR
Copy link
Member Author

wRAR commented Jan 31, 2020

This is even more confusing, actually. And it's not what I wanted to create this ticket about initially.

There is another Slot, scrapy.core.scraper.Slot, and it has a one-to-one rel with scrapy.core.scraper.Scraper, which was many-to-one before 58975ab.

There is also scrapy.core.downloader.Slot, which still has a many-to-one rel with scrapy.core.downloader.Downloader :)

@Gallaecio
Copy link
Member

If nothing else, we should rename those classes 😄

@nyov
Copy link
Contributor

nyov commented Feb 24, 2020

Yeah, they should definitely be called Spot. ;)

#1392

Just get rid of them, if they have no point, aye?

@apurvTri123
Copy link

Hi can I work on this?

@wRAR
Copy link
Member Author

wRAR commented Mar 19, 2020

hi @apurvTri123 , this is a discussion ticket, we are not sure what do we want to do with this, if anything at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants