Support schema-less HTTP proxy (#4504) #4649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4649 +/- ##
=======================================
Coverage 88.18% 88.19%
=======================================
Files 162 162
Lines 10490 10497 +7
Branches 1516 1517 +1
=======================================
+ Hits 9251 9258 +7
Misses 965 965
Partials 274 274
|
wRAR
approved these changes
Jun 29, 2020
Gallaecio
reviewed
Jun 29, 2020
|
Other than that minor change, I’ve verified that the test correctly covers the underlying issue, so good work! |
ajaymittur
commented
Jul 1, 2020
Gallaecio
approved these changes
Jul 1, 2020
wRAR
reviewed
Jun 14, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4505
Implemented the solution suggested by @Gallaecio in this PR.