Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Reppy support #5230

Closed
Gallaecio opened this issue Aug 16, 2021 · 7 comments · Fixed by #6099
Closed

Deprecate Reppy support #5230

Gallaecio opened this issue Aug 16, 2021 · 7 comments · Fixed by #6099
Labels
Milestone

Comments

@Gallaecio
Copy link
Member

#5226 (comment)

@umairnsr87
Copy link
Contributor

https://docs.scrapy.org/en/latest/topics/downloader-middleware.html#built-in-downloader-middleware-reference @Gallaecio I am seeing that Reappy Parser Do I just need to mention there that "only work with Python 3.8 and earlier" or do I need to make some other changes. Thanks

@Gallaecio
Copy link
Member Author

Gallaecio commented Aug 16, 2021

That’s it.

Please, do it as part of #5226, this ticket is for potential future work deprecating support for Reppy.

@Gallaecio
Copy link
Member Author

@felipeboffnunes
Copy link
Member

@Gallaecio do we need to update once more the docs to mention gcc's current issue for previous versions of python? Or can we close as-is?

@Gallaecio
Copy link
Member Author

Neither. I would not bother changing the docs, but this needs to remain open until we actually deprecate Reppy support, to be done around Oct 14th 2023. i.e. 1 year before Python 3.8 end of life, as agreed.

@felipeboffnunes
Copy link
Member

Nice, thanks @Gallaecio !

giphy

@wRAR
Copy link
Member

wRAR commented Oct 16, 2023

This is now ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants