Document Spider.update_settings

[wRAR]

While overriding Spider.update_settings is a common practice to have dynamic custom settings, it looks like it's not documented anywhere.

It should also be mentioned in https://docs.scrapy.org/en/latest/topics/settings.html#settings-per-spider

[anugcodes]

hey @wRAR , i would like to try this issue.But i am new here and don't know where to start.can you please help me out here.

[wRAR]

@anugcodes are you asking about contributing in general or how to fix this issue?

[anugcodes]

@anugcodes are you asking about contributing in general or how to fix this issue?

I mean in general,how can I understand the codebase and start with beginner friendly tasks.

[wRAR]

@anugcodes https://docs.scrapy.org/en/latest/contributing.html

[N00rAhmed]

hey @wRAR I would like to work on this issue but because I'm new to this repo I dont know where I should write the documentation for Spider.update_settings ?

[wRAR]

@N00rAhmed the attributes of scrapy.Spider are documented in docs/topics/spiders.rst.

[tuhinmallick]

Is this issue still open then I would like to work on it

[wRAR]

@tuhinmallick there is an existing not-yet-complete PR linked above but you can try too.

[tuhinmallick]

@wRAR Thanks I have made a PR #5784 . Please let me know if i have to modify anything or improve something

[jxlil]

Hi @wRAR, I tried to document update_settings in this PR #5846. Do you think I should make any other changes? Thanks!